bpo-35416: Fix potential resource warnings in distutils#10918
Merged
methane merged 2 commits intopython:masterfrom Apr 8, 2019
Merged
bpo-35416: Fix potential resource warnings in distutils#10918methane merged 2 commits intopython:masterfrom
methane merged 2 commits intopython:masterfrom
Conversation
BoboTiG
force-pushed
the
fix-resource-warning-unclosed-file-distutils
branch
from
2af99ff to
bbcfda4
Compare
Member
|
Thanks, this looks good! There are a few instances of weird indentation (from before your patch), I would like to take the opportunity to clean them. |
Contributor
Author
|
Of course, go ahead :) |
Member
|
Easier if I do them! It could take me a couple weeks though. Another PR with some of the fixes was just merged, so part of the codebase is already better. |
Contributor
Author
|
Good :) |
serhiy-storchaka
approved these changes
Dec 20, 2018
merwok
reviewed
Apr 8, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent file descriptor leaks in distutils.
https://bugs.python.org/issue35416